refactor(async_rollout_worker): renamed tool variables to mirror grpo_trainer.py#5332
Merged
Merged
Conversation
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a small refactor following @qgallouedec #5330 (comment) in my previous PR.
To harmonize
async_rollout_worker.pywithgrpo_trainer.pytool variables:_build_messages_suffix_ids → _get_tool_suffix_ids
messages → tool_messages
template_messages → dummy_messages
prefix_and_messages_ids → full_ids
tool_suffix_ids → suffix_ids
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Note
Low Risk
Pure refactor limited to tool-message suffix tokenization and variable renames; behavior should be unchanged but could affect tool-call prompting if the suffix slicing logic is accidentally altered.
Overview
Refactors
AsyncRolloutWorkertool-call handling to mirrorgrpo_trainer.pynaming and structure.Renames
_build_messages_suffix_idsto_get_tool_suffix_idsand consistently renames related locals (messages→tool_messages,template_messages→dummy_messages,prefix_and_messages_ids→full_ids,tool_suffix_ids→suffix_ids) while keeping the same suffix-ID computation and call site in_generate_one.Written by Cursor Bugbot for commit 0da28b1. This will update automatically on new commits. Configure here.